1604 sys2 accmoboi
DESCRIPTION
Nxncuc yTRANSCRIPT
![Page 1: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/1.jpg)
Patch ReviewsThanks ZenDoodles and xjm
![Page 2: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/2.jpg)
YesCTCathy Theys
@YesCTCheppers, Gittip
I review patches, mostly for core these days.
And do other stuff like plan sprints and mentor.
![Page 4: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/4.jpg)
![Page 5: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/5.jpg)
Getting patch reviewsAlso: how to find reviews
![Page 6: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/6.jpg)
Be specific,what kind of review?
![Page 7: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/7.jpg)
Use tagsneeds JavaScript reviewneeds architectural review,needs usability review,needs manual testing,needs screenshot
![Page 8: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/8.jpg)
Up-to-date Issue Summaryhttps://drupal.org/contributor-tasks/write-issue-summary
![Page 9: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/9.jpg)
![Page 10: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/10.jpg)
![Page 11: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/11.jpg)
![Page 12: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/12.jpg)
![Page 13: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/13.jpg)
Automatic instructionswork in progress at
https://drupal.org/node/2013222
![Page 14: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/14.jpg)
Contributor taskdocuments
http://drupal.org/contributor-tasks/review
http://drupal.org/contributor-tasks/do-accessibility-review
![Page 15: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/15.jpg)
Metas
![Page 16: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/16.jpg)
![Page 17: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/17.jpg)
![Page 18: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/18.jpg)
simplytest.me urlpattern is:
/project/drupal/8.x?patch[]=
http://simplytest.me/qa#developers
![Page 19: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/19.jpg)
Give good reviews
![Page 20: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/20.jpg)
Doing patch reviews
![Page 21: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/21.jpg)
Finding issues toreview
![Page 22: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/22.jpg)
first simple! success!novice?initiativesmetas?focus?
![Page 23: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/23.jpg)
![Page 24: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/24.jpg)
![Page 25: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/25.jpg)
![Page 26: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/26.jpg)
![Page 27: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/27.jpg)
![Page 28: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/28.jpg)
Core initiativeshttps://drupal.org/community-initiatives/drupal-core
and https://drupal.org/node/2107085
![Page 29: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/29.jpg)
![Page 30: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/30.jpg)
![Page 31: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/31.jpg)
![Page 32: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/32.jpg)
![Page 33: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/33.jpg)
![Page 34: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/34.jpg)
![Page 35: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/35.jpg)
![Page 36: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/36.jpg)
![Page 37: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/37.jpg)
![Page 38: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/38.jpg)
Doing patch reviews
![Page 39: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/39.jpg)
Full frontal nicety
![Page 40: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/40.jpg)
Supportivespecificinclude linkssupport improvementask questionseducate
![Page 41: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/41.jpg)
![Page 42: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/42.jpg)
![Page 43: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/43.jpg)
http://dreditor.org
![Page 44: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/44.jpg)
![Page 45: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/45.jpg)
![Page 46: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/46.jpg)
![Page 47: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/47.jpg)
![Page 48: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/48.jpg)
![Page 49: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/49.jpg)
![Page 50: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/50.jpg)
![Page 51: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/51.jpg)
![Page 52: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/52.jpg)
![Page 53: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/53.jpg)
![Page 54: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/54.jpg)
![Page 55: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/55.jpg)
![Page 56: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/56.jpg)
![Page 57: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/57.jpg)
![Page 58: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/58.jpg)
![Page 59: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/59.jpg)
![Page 60: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/60.jpg)
![Page 61: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/61.jpg)
![Page 62: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/62.jpg)
![Page 63: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/63.jpg)
![Page 64: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/64.jpg)
![Page 65: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/65.jpg)
![Page 66: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/66.jpg)
![Page 67: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/67.jpg)
![Page 68: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/68.jpg)
Does it work?fixes the issuestays in scopeno regressions
![Page 69: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/69.jpg)
![Page 70: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/70.jpg)
![Page 71: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/71.jpg)
![Page 72: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/72.jpg)
![Page 73: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/73.jpg)
![Page 74: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/74.jpg)
![Page 75: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/75.jpg)
![Page 76: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/76.jpg)
![Page 77: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/77.jpg)
Edit
![Page 78: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/78.jpg)
![Page 79: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/79.jpg)
![Page 80: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/80.jpg)
![Page 81: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/81.jpg)
![Page 82: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/82.jpg)
![Page 83: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/83.jpg)
![Page 84: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/84.jpg)
![Page 85: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/85.jpg)
![Page 86: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/86.jpg)
![Page 87: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/87.jpg)
![Page 88: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/88.jpg)
Does it make sense?readable?comments?is there a better way?
![Page 89: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/89.jpg)
![Page 90: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/90.jpg)
![Page 91: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/91.jpg)
![Page 92: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/92.jpg)
![Page 93: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/93.jpg)
![Page 94: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/94.jpg)
![Page 95: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/95.jpg)
StrategyScale
say whatsay how
![Page 96: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/96.jpg)
StrategyKinds of reviews
update the issue summaryupdate needs tags
![Page 97: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/97.jpg)
Processcannot unreadperfect is enemy of good
![Page 98: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/98.jpg)
![Page 99: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/99.jpg)
![Page 100: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/100.jpg)
![Page 101: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/101.jpg)
documentationissue summarytimein-code API docs (1354)hook_help()change records
http://drupal.org/list-changes/drupal
![Page 102: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/102.jpg)
PerformanceDon't guessprofile!
![Page 103: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/103.jpg)
Accessibility
![Page 104: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/104.jpg)
bugWCAGATAGtext color contrastform fields are labeledkeyboard-usable (javascript)
![Page 105: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/105.jpg)
UsabilityUI changes need usabilityreviewbefore and after screenshots
![Page 106: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/106.jpg)
Testingcheck coverageask for new testsverify tests-only fails
![Page 107: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/107.jpg)
Coding Styleno tabs, trailing1354link! to docs
![Page 108: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/108.jpg)
drupal.org/documentation/git/interdiff
![Page 109: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/109.jpg)
Read and checkconcerns?addressed?
![Page 110: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/110.jpg)
read, read, readfix simplefor scopefor understanding
![Page 111: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/111.jpg)
IDE
![Page 112: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/112.jpg)
Resourcesdrupalize.me/guides/drupal-community-tools-and-core-mentoring
![Page 113: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/113.jpg)
![Page 114: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/114.jpg)
Resourcesdrupalladder.org/
![Page 115: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/115.jpg)
Resourcesdrupal.org/contributor-tasks/reviewxjm.drupalgardens.com/review-guide
![Page 116: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/116.jpg)
Actiondrupal mentoring office hours#drupal-contributedrupical.com
![Page 117: 1604 sys2 accmoboi](https://reader033.vdocuments.pub/reader033/viewer/2022042517/5e97caca26281410183a9b8e/html5/thumbnails/117.jpg)
Thanks!https://drupal.org/node/2013222
https://drupal.org/core-mentoring